Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Dockerfile image and Fix/Add documentation #6

Conversation

fsantamaria1
Copy link
Member

@fsantamaria1 fsantamaria1 commented Apr 7, 2024

To run:
Install Docker
Run docker compose up

  • Corrected documentation to remove extra space
  • Corrected the Dockerfile and changed image to eclipse-temurin:17 in order to support Mac users with M1 chip. This changed the size of the image from 345MB to 427MB. We could investigate how to make image leaner.
  • Introduced new documentation for Windows users to address this issue

Fixes #4

…c users, and added docs for Windows users Fixes #4
@fsantamaria1 fsantamaria1 changed the base branch from main to mariorecinos-testing-reviewers-added-pr-4 April 7, 2024 16:59
@fsantamaria1 fsantamaria1 changed the title Fsantamaria1 testing reviewers 4 Change Dockerfile image and Fix/Add documentation Apr 7, 2024
Copy link
Member

@MelisaIm MelisaIm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! <3

@MelisaIm
Copy link
Member

MelisaIm commented Apr 7, 2024

@lindentree please confirm when you have time that this resolves the issue for M1 (I would be shook if it worked on M2 but not M1)

@lindentree
Copy link

@lindentree please confirm when you have time that this resolves the issue for M1 (I would be shook if it worked on M2 but not M1)

Yep, tested it locally

Copy link

@lindentree lindentree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fsantamaria1! LGTM!

@fsantamaria1 fsantamaria1 merged commit 385c6e4 into mariorecinos-testing-reviewers-added-pr-4 Apr 8, 2024
3 checks passed
@fsantamaria1 fsantamaria1 deleted the fsantamaria1-testing-reviewers-4 branch April 8, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing-Reviewers-Being Added
3 participants